Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Start using "v" prefix for tags #865

Open
glyn opened this issue Sep 17, 2019 · 2 comments
Open

Start using "v" prefix for tags #865

glyn opened this issue Sep 17, 2019 · 2 comments
Milestone

Comments

@glyn
Copy link
Contributor

glyn commented Sep 17, 2019

This is for consistency with cnab-go.

Also https://semver.org/spec/v1.0.0.html#tagging-specification-semvertag favours this:

When tagging releases in a version control system, the tag for a version MUST be “vX.Y.Z” e.g. “v3.1.0”.

@glyn glyn added this to the Duffle 1.0 milestone Sep 17, 2019
@thaney071
Copy link

Your developer guide page points to the semversion 2.0.0 webpage, but your issue is for a 1.0.0 part of the spec. 2.0.0 has removed this suggestion and now has this in the FAQ:
https://semver.org/#is-v123-a-semantic-version

If you are intending to use semver 1.0.0, then the link might need to be updated. Otherwise, it would be better to state this is for consistency with other parts of the cnab project.

@carolynvs
Copy link
Contributor

@thaney071 Correct, as Glyn said we would like to be consistent with the other cnabio projects which use the v prefix for our git tags.

We do follow semver 2 for the CNAB spec for bundle version by the way, the bundle.json version field doesn't use a v prefix. This issue is only applicable to the git tag for this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants