Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread safe function #29

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Use thread safe function #29

merged 1 commit into from
Apr 15, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 15, 2021

what

  • Use thread safe function to generate object IDs

why

  • Terraform performs actions in parallel, so using a global variable is not safe
panic: d.nx != 0
plugin.terraform-provider-utils_v0.4.2: 
plugin.terraform-provider-utils_v0.4.2: goroutine 61 [running]:
plugin.terraform-provider-utils_v0.4.2: crypto/sha1.(*digest).checkSum(0xc000497778, 0x0, 0x0, 0xec943cb500000000)

@Nuru Nuru added the bugfix Change that restores intended behavior label Apr 15, 2021
@Nuru Nuru requested review from a team as code owners April 15, 2021 22:17
@Nuru Nuru requested review from Gowiem, adamcrews and aknysh and removed request for Gowiem and adamcrews April 15, 2021 22:17
@Nuru Nuru merged commit 23f9be2 into main Apr 15, 2021
@Nuru Nuru deleted the concurrency-bugfix branch April 15, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh