ATMOS 1.10.1: Fix atmos
CLI config processing. Improve logs.verbose
#209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
atmos
CLI config processinglogs.verbose
why
utils
provider. Remove all global vars from Go code. ImplementLogs.Verbose
. Updateterraform
commands atmos#210Go
, a struct is passed by value to a function (the whole struct is copied), so if the function modifies any struct fields, the changes are not visible from outside of the functionsprocessEnvVars
was accepting the CLI config struct by value, checking the ENV varATMOS_BASE_PATH
and modifying theBasePath
field - this modification was lost when the function returned resulting in the error from theutils
provider "failed to find a match for the import ..." because theatmos
base path was not set correctly (note thatATMOS_BASE_PATH
ENV var is critical for theutils
provider to work, and it's set bygeodesic
or by Spacelift scripts)references
atmos
CLI config processing. Improvelogs.verbose
atmos#211