Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload_manifest.py opens a port to the world, and always the same port #1017

Closed
nyh opened this issue Nov 26, 2018 · 0 comments
Closed

upload_manifest.py opens a port to the world, and always the same port #1017

nyh opened this issue Nov 26, 2018 · 0 comments

Comments

@nyh
Copy link
Contributor

nyh commented Nov 26, 2018

We've seen Jenkins runs fail, e.g., http://jenkins.cloudius-systems.com:8080/job/osv-build-nightly/1666/console, because port 10000 was not available during the build. Presumably because a previous build hung and kept it open, or some other program on the system used the same port number.

upload_manifest.py uses port 10000 on the host to communicate with the cpiod inside the guest to install files.

Firstly, we should trivially modify it to pick the host port randomly instead of always using "10000" (note that one of the occurances in "10000" in that code - the guest port number - should remain unchanged).

Secondly, we should modify the --forward line to only open this port inside the host - not to the entire world. This is also very easy - instead of "--forward tcp::1234-:10000'" do "--forward tcp:127.0.0.1:1234-:10000'

There's a similar issue for imgedit.py: see issue #709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant