Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getArticles does not use cursor based pagination #732

Closed
shalabi opened this issue Dec 14, 2024 · 1 comment · Fixed by #733
Closed

getArticles does not use cursor based pagination #732

shalabi opened this issue Dec 14, 2024 · 1 comment · Fixed by #733
Assignees

Comments

@shalabi
Copy link
Contributor

shalabi commented Dec 14, 2024

Describe the bug
getArticles does not use cursor based pagination

To Reproduce
Call getArtficles on large help centers fails. Returns error:

HTTP/400: Bad Request - {"error":"LimitError","description":"Offset-based pagination is limited to 100 pages"}

Looking at code

  public Iterable<Article> getArticles() {
    return new PagedIterable<>(
        cnst("/help_center/articles.json"), handleList(Article.class, "articles"));
  }

should be:

  public Iterable<Article> getArticles() {
    return new PagedIterable<>(
        cbp("/help_center/articles.json"), handleList(Article.class, "articles"));
  }

Expected behavior
Cursor based pagination

@shalabi
Copy link
Contributor Author

shalabi commented Dec 14, 2024

Seems this needs to happen for all the article endpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants