-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar starts to wrap #894
Comments
We need a dynamic grouping mechanism I described before #817 (comment) |
BTW, in examples, there's no ToC on the right, so we might make the content a bit wider. |
I created a quick fix for the limited horizontal space issue by adjusting the Umberto container width in the examples/builds/document-editor.html (see the commit). Unfortunately, we cannot use this fix in the guide (framework/guides/ui/document-editor.html) because it has the TOC on the right side, which limits the space. We might need some option in Umberto to use a wider layout when necessary for examples/guides like this one. |
In #1472 @dashingswags proposed a bit different approach to the UI (the 3 dots and the menu look). I quite liked it. We don't have such a component your so we'd need to think how to propose it (to avoid weird duplication) if we want to make it reusable. If not, we could just implement similar look&feel. One issue that I see with #dashingswags's solution is that dropdowns or split buttons won't work in such a panel. Would this be a deal breaker? |
Tested with dropdowns before initiating a pull request which works well too. |
Closed in #416. |
Well... we said that we ignore this scenario for now because it's the implementor's role to take care of this (by not using too many features or using wide enough toolbar. And here we are ;)
The text was updated successfully, but these errors were encountered: