Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy monorepo changes #6534

Closed
mlewand opened this issue Apr 2, 2020 · 3 comments
Closed

Deploy monorepo changes #6534

mlewand opened this issue Apr 2, 2020 · 3 comments
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@mlewand
Copy link
Contributor

mlewand commented Apr 2, 2020

Provide a description of the task

This will be a final step in our migration.

We can't just partially deploy the work to ckeditor5 repo (a lot of things will break). Instead we're verifying our work on a different, sandbox clone of ckeditor5 repository and we're creating an instruction that should be followed during the deploy.

@mlewand mlewand added the type:task This issue reports a chore (non-production change) and other types of "todos". label Apr 2, 2020
@mlewand mlewand added this to the iteration 31 milestone Apr 2, 2020
@Reinmar Reinmar mentioned this issue Apr 2, 2020
7 tasks
@mlewand
Copy link
Contributor Author

mlewand commented Apr 2, 2020

Steps

  • Consider merging stable to master in ckeditor5-* repos.
  • Merge the monorepo-pending branch to master in all packages, except main ckeditor5 repository.
  • Merge all subpackages to the main ckeditor5 repository (instruction)
  • Merge the monorepo (created in previous step) and monorepo-pending branch to master in the main repository.
  • Cleanup all the ckeditor5-* (subpackage) repositories
    • Update readmes with information that repositories are no longer maintained and main repo should be used
    • Archive all repos
  • Merge master branch to the stable branch - new structure and docs should be applied to stable branch too
    • Rebuild & publish updated documentation
  • Merge monorepo branch in ckeditor/ckeditor5-dev repository.

Post deploy testing

  • Prepare a sample PR that breaks unit tests.
  • Prepare a sample PR that reduced the CC.
  • Close/remove all the test PRs made while testing.
  • Remove merged monorepo migration branches
    • monorepo-pending
    • monorepo-post-migration

@pomek
Copy link
Member

pomek commented Apr 2, 2020

Remove lint task from package.json, delete .gitignore and other files in a directory that isn't an alone repository anymore. Review package.json – dev/dependencies, repository URL, bugs URL etc.
I do not recommend doing it manually. A script for doing this could be helpful.

@mlewand
Copy link
Contributor Author

mlewand commented May 4, 2020

All right, all the necessary steps were performed. Docs deployment and repo archive will be handled later.

@mlewand mlewand closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants