Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Position#getCommonAncestor( otherPosition ) and Range#getCommonAncestor() #4105

Closed
pomek opened this issue Jul 6, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1005
Closed

Introduce Position#getCommonAncestor( otherPosition ) and Range#getCommonAncestor() #4105

pomek opened this issue Jul 6, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1005
Assignees
@pomek
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@pomek
Copy link
Member

pomek commented Jul 6, 2017

In order to properly resolve this ticket – https://github.com/ckeditor/ckeditor5-typing/issues/61#issuecomment-313341258 – we need to introduce two methods:

  • Position#getCommonAncestor( otherPosition ) - should return the common ancestor for two positions,
  • Range#getCommonAncestor() - should return the common ancestor for the range's positions.
@pomek pomek self-assigned this Jul 6, 2017
@Reinmar
Copy link
Member

Reinmar commented Jul 6, 2017

We should also add these methods in the view Position and view Range classes.

Reinmar referenced this issue in ckeditor/ckeditor5-engine Jul 11, 2017
@Reinmar
Merge pull request #1005 from ckeditor/t/1002
0e29844 
Feature: Introduced `Position#getCommonAncestor( position )` and `Range#getCommonAncestor()` methods for the view and model. Closes #1002.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:model type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:engine labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
3 participants
@Reinmar @pomek @mlewand