Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was Document#_roots made public? #4002

Closed
Reinmar opened this issue Feb 25, 2017 · 3 comments
Closed

Why was Document#_roots made public? #4002

Reinmar opened this issue Feb 25, 2017 · 3 comments

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 25, 2017

I see it was made public in ckeditor/ckeditor5-engine#813. Why? Couldn't it be protected if the dev utils need to access them? Besides, wasn't Document#getRootNames() + Document#getRoot() + Document#graveyard enough?

@Reinmar
Copy link
Member Author

Reinmar commented Feb 25, 2017

cc @scofalik @szymonkups

@Reinmar Reinmar changed the title Why was Document#roots made public? Why was Document#_roots made public? Feb 25, 2017
@scofalik
Copy link
Contributor

AFAIR, it was made public during writing logging tools for engine. I noticed that the implementation between ModelDocument and ViewDocument is different. I haven't seen that ModelDocument has getRootNames though.

If that's the case, we can think of unifying the implementations by making _roots private for both model and view document, and introduce getRootNames() for ViewDocument.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 5, 2018

I think it's gone now, so closing.

@Reinmar Reinmar closed this as completed Apr 5, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants