-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block toolbar UI improvements #5456
Comments
BTW, @oleq, I miss your new heading icons. |
Me too! Haven't got enough time to finish them, though. |
I am not sure about serif pilcrow icon. We changed it to the simpler one in Letters some time ago since the whole UI is simple. The rest 👍. |
👍 For the pilcrow icon. Stylish and smooooth ;> 👍 For p/h1/h2/h3. Much better weight and alignment. 👍 For focus. I love the transitions. |
More visible focus than ATM 👍 👍 👍 TBH, to our "flat & simple" UI this pilcrow icon is too stylish. |
…ow. Ensured the balloon panel's arrow does not cover panel's children. Closes #394.
…k-button (also .ck-input). Obsoleted the background color change on .ck-button:focus to avoid situations when a focused button looks like an active one (see ckeditor/ckeditor5-ui#394).
Visually the serif icon looks better but it doesn't fit the rest of the toolbar, so I am torn. I also like a bigger padding - more space for clicking the button. Lastly, I wouldn't mind some kind of border or maybe only shadow, hinting that this icon is something clickable. |
I had a similar feeling in the past. Perhaps we could do something about it (not necessarily in this ticket, though). |
Other: Allowed list item's buttons to have an outer, visible box-shadow. Ensured the balloon panel's arrow does not cover panel's children. Closes #394.
Other: Used a solid box-shadow to indicate the :focus state of the .ck-button (also .ck-input). Obsoleted the background color change on .ck-button:focus to avoid situations when a focused button looks like an active one (see ckeditor/ckeditor5-ui#394). BREAKING CHANGE: Various color variables --ck-color-button-...-focus have been renamed to --ck-color-button-...-hover.
Other: Refreshed the paragraph icon (see ckeditor/ckeditor5-ui#394).
Other: Refreshed the heading icons (see ckeditor/ckeditor5-ui#394).
Other: Refreshed the pilcrow icon (see ckeditor/ckeditor5-ui#394).
Follow-up of ckeditor/ckeditor5-ui#392.
I wanted to report that paragraph is allways "on". Then I realised that it is only selected. However, I asked one more person "what is wrong with this panel" and he also said that paragraph is "on". We need a lighter style for focused items.
I want to make this ticket more generric to gather whole feedback about the UI of block toolbar in CKE 5.
The text was updated successfully, but these errors were encountered: