Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block toolbar UI improvements #5456

Closed
pjasiun opened this issue May 22, 2018 · 9 comments · Fixed by ckeditor/ckeditor5-ui#422
Closed

Block toolbar UI improvements #5456

pjasiun opened this issue May 22, 2018 · 9 comments · Fixed by ckeditor/ckeditor5-ui#422
Assignees
Labels
package:ui status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@pjasiun
Copy link

pjasiun commented May 22, 2018

Follow-up of ckeditor/ckeditor5-ui#392.

paragrah-too-strong

I wanted to report that paragraph is allways "on". Then I realised that it is only selected. However, I asked one more person "what is wrong with this panel" and he also said that paragraph is "on". We need a lighter style for focused items.

I want to make this ticket more generric to gather whole feedback about the UI of block toolbar in CKE 5.

@Reinmar
Copy link
Member

Reinmar commented Jun 8, 2018

cc @oleq @dkonopka

@Reinmar
Copy link
Member

Reinmar commented Jun 25, 2018

BTW, @oleq, I miss your new heading icons.

@oleq
Copy link
Member

oleq commented Jul 2, 2018

Me too! Haven't got enough time to finish them, though.

@oleq
Copy link
Member

oleq commented Jul 3, 2018

I propose 2 kinds of improvements:

New icons

kapture 2018-07-03 at 15 42 48

kapture 2018-07-03 at 15 44 09

Focus style improvements

Note: Old icons here as the new ones haven't been SVG'd yet.

kapture 2018-07-03 at 15 28 51
kapture 2018-07-03 at 15 26 22
kapture 2018-07-03 at 15 27 36

@pjasiun
Copy link
Author

pjasiun commented Jul 3, 2018

I am not sure about serif pilcrow icon. We changed it to the simpler one in Letters some time ago since the whole UI is simple. The rest 👍.

@Reinmar
Copy link
Member

Reinmar commented Jul 3, 2018

👍 For the pilcrow icon. Stylish and smooooth ;>

👍 For p/h1/h2/h3. Much better weight and alignment.

👍 For focus. I love the transitions.

@dkonopka
Copy link
Contributor

dkonopka commented Jul 3, 2018

More visible focus than ATM 👍 👍 👍 TBH, to our "flat & simple" UI this pilcrow icon is too stylish.

oleq referenced this issue in ckeditor/ckeditor5-ui Jul 4, 2018
…ow. Ensured the balloon panel's arrow does not cover panel's children. Closes #394.
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Jul 4, 2018
…k-button (also .ck-input). Obsoleted the background color change on .ck-button:focus to avoid situations when a focused button looks like an active one (see ckeditor/ckeditor5-ui#394).
@scofalik
Copy link
Contributor

scofalik commented Jul 4, 2018

Visually the serif icon looks better but it doesn't fit the rest of the toolbar, so I am torn. I also like a bigger padding - more space for clicking the button. Lastly, I wouldn't mind some kind of border or maybe only shadow, hinting that this icon is something clickable.

@Reinmar
Copy link
Member

Reinmar commented Jul 4, 2018

Lastly, I wouldn't mind some kind of border or maybe only shadow, hinting that this icon is something clickable.

I had a similar feeling in the past. Perhaps we could do something about it (not necessarily in this ticket, though).

dkonopka referenced this issue in ckeditor/ckeditor5-ui Jul 6, 2018
Other: Allowed list item's buttons to have an outer, visible box-shadow. Ensured the balloon panel's arrow does not cover panel's children. Closes #394.
dkonopka referenced this issue in ckeditor/ckeditor5-theme-lark Jul 6, 2018
Other: Used a solid box-shadow to indicate the :focus state of the .ck-button (also .ck-input). Obsoleted the background color change on .ck-button:focus to avoid situations when a focused button looks like an active one (see ckeditor/ckeditor5-ui#394).

BREAKING CHANGE: Various color variables --ck-color-button-...-focus have been renamed to --ck-color-button-...-hover.
dkonopka referenced this issue in ckeditor/ckeditor5-paragraph Jul 6, 2018
Other: Refreshed the paragraph icon (see ckeditor/ckeditor5-ui#394).
dkonopka referenced this issue in ckeditor/ckeditor5-heading Jul 6, 2018
Other: Refreshed the heading icons (see ckeditor/ckeditor5-ui#394).
dkonopka referenced this issue in ckeditor/ckeditor5-core Jul 6, 2018
Other: Refreshed the pilcrow icon (see ckeditor/ckeditor5-ui#394).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants