Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder pseudo–element has low contrast #3421

Closed
oleq opened this issue Jan 16, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#217
Closed

Placeholder pseudo–element has low contrast #3421

oleq opened this issue Jan 16, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#217
Assignees
@oleq

Comments

@oleq
Copy link
Member

oleq commented Jan 16, 2019

ATM it's https://github.com/ckeditor/ckeditor5-theme-lark/blob/master/theme/ckeditor5-ui/globals/_colors.css#L95 (#c2c2c2). We need at least #757575 to pass WCAG AA on a white background and #717171 to pass in <figcaption> which has a gray bg.

Related to #479.
@oleq oleq self-assigned this Jan 16, 2019
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Jan 17, 2019
@oleq
Fix: Made the .ck-placeholder text WCAG AA compliant. Closes #213.
57bcd16
pjasiun referenced this issue in ckeditor/ckeditor5-theme-lark Feb 7, 2019
Merge pull request #217 from ckeditor/t/ckeditor5/479
cff6cad 
Fix: The placeholder text should have more contrast to meet the WCAG AA standard. Closes #213.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T/ckeditor5/479: The placeholder text should have more contrast ckeditor/ckeditor5-theme-lark
1 participant
@oleq