-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why are widgets' margin and padding styled here? #3419
Comments
Just to be clear: do you want these styles removed or moved to some other place? |
If they are needed, they should be applied by specific widgets (that need them). Although, I'm really curious which features really need them in the first place. That will answer the question whether it makes sense if they are generalised like that. |
I wasn't able to determine why we need As for the margin, I moved this style to image and media-embed and aligned to the table (which already has it). |
Other: Moved widget spacing styles to respective content styles in packages. Closes #209.
Other: Moved widget spacing styles from ckeditor5-theme-lark to the feature content styles sheet (see ckeditor/ckeditor5-theme-lark#209).
Other: Moved widget spacing styles from ckeditor5-theme-lark to the feature content styles sheet (see ckeditor/ckeditor5-theme-lark#209).
https://github.com/ckeditor/ckeditor5-theme-lark/blob/41d7d1e0eeae5517ef605bf6cd0e2977249d7d14/theme/ckeditor5-widget/widget.css#L22-L23
This is odd. Widgets system is a generic system and should not assume anything beyond how widgets react to selection/focus/etc.
I stumbled upon this because every time I wanted to write a "simple box"-like widget, I had to fight with the specificity of these styles.
The text was updated successfully, but these errors were encountered: