Merge pull request #196 from ckeditor/t/ckeditor5/1151

Other: Adjusted `InsertTableView` for better compatibility with right–to–left (RTL) languages. See ckeditor/ckeditor5#1151.
ckeditor · Aug 12, 2019 · 524586b · 524586b
2 parents 4569d21 + 92d8f87
commit 524586b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/ui/inserttableview.js b/src/ui/inserttableview.js
@@ -59,7 +59,7 @@ export default class InsertTableView extends View {
 		 * @member {String} #label
 		 */
 		this.bind( 'label' )
-			.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } x ${ columns }` );
+			.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } × ${ columns }` );
 
 		this.setTemplate( {
 			tag: 'div',

diff --git a/tests/ui/inserttableview.js b/tests/ui/inserttableview.js
@@ -39,7 +39,7 @@ describe( 'InsertTableView', () => {
 		} );
 
 		it( 'sets #label to default rows & columns', () => {
-			expect( view.label ).to.equal( '0 x 0' );
+			expect( view.label ).to.equal( '0 × 0' );
 		} );
 
 		it( 'creates #element from template', () => {
@@ -85,11 +85,11 @@ describe( 'InsertTableView', () => {
 			it( 'binds #label to rows & columns', () => {
 				view.rows = 3;
 
-				expect( view.label ).to.equal( '3 x 0' );
+				expect( view.label ).to.equal( '3 × 0' );
 
 				view.columns = 7;
 
-				expect( view.label ).to.equal( '3 x 7' );
+				expect( view.label ).to.equal( '3 × 7' );
 			} );
 
 			it( 'mousedown event should be prevented', () => {