Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for bold defined as numeric value #5563

Closed
msamsel opened this issue Jul 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-basic-styles#96
Closed

Provide support for bold defined as numeric value #5563

msamsel opened this issue Jul 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-basic-styles#96
Assignees
@pomek
Labels
package:basic-styles type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 27 (v15...

Comments

@msamsel
Copy link
Contributor

msamsel commented Jul 19, 2019

Feature request:

During work on ckeditor/ckeditor5-paste-from-office#20, I noticed that google docs use the numeric value to define bold.

font-weight: 700

It could be great to start to support it and automatically upcast such values to bold attribute from any source. Bold might be defined as 700 (which should be the same as 'bold'), or any value above 600 (which is semi-bold).
jodator referenced this issue in ckeditor/ckeditor5-basic-styles Aug 29, 2019
@jodator
Merge pull request #96 from ckeditor/t/94
25a0d7c 
Feature: Provided support for numeric values for the `font-weight` attribute. Closes #94. Closes ckeditor/ckeditor5-paste-from-office#74.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-basic-styles Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:basic-styles labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:basic-styles type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

Support for numeric values in the font-weight attribute ckeditor/ckeditor5-basic-styles
3 participants
@pomek @mlewand @msamsel