fix: Handle int64 as BigInt from jsonSchema #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PredaaA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z.bigint()will be interpreted by jsonSchema as{ type: 'integer', format: 'int64' }.Which means that
parseFormDataEntrywill parseInt during the switch(type). For a value of "337224005901615104", it will return "337224005901615100" instead, and superforms will return a 400 with "Expected bigint, received number".This check earlier if it's an integer with format int64 and if so return it as a BigInt.
I'm not sure if this should be done earlier though, in jsonSchema file directly during
schemaTypescall. Let me know what you think.