Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent funding the same loan 2x #152

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Prevent funding the same loan 2x #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e62051
Prevent funding an already-funded loan
Dec 9, 2022
573304e
Remove .only
Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contracts/Pool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@ contract Pool is IPool, ERC20Upgradeable, BeaconImplementation {
onlyPoolController
onlyCrankedPool
{
require(!_fundedLoans[addr], "Pool: already funded");
_fundedLoans[addr] = true;
ILoan loan = ILoan(addr);
uint256 principal = loan.principal();

Expand All @@ -260,7 +262,6 @@ contract Pool is IPool, ERC20Upgradeable, BeaconImplementation {
loan.fund();

_accountings.outstandingLoanPrincipals += principal;
_fundedLoans[addr] = true;

emit LoanFunded(addr, principal);
}
Expand Down
29 changes: 29 additions & 0 deletions test/controllers/PoolController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,6 +969,35 @@ describe("PoolController", () => {
poolController.connect(otherAccount).fundLoan(otherAccount.address)
).to.be.revertedWith("Pool: caller is not admin");
});

it("reverts if trying to fund the same loan again", async () => {
const {
pool,
liquidityAsset,
otherAccount,
borrower,
poolAdmin,
loan,
poolController
} = await loadFixture(loadPoolFixture);

await activatePool(pool, poolAdmin, liquidityAsset);
await collateralizeLoan(loan, borrower, liquidityAsset);
await depositToPool(
pool,
otherAccount,
liquidityAsset,
DEFAULT_LOAN_SETTINGS.principal * 3
);

// fund loan 1 time
await fundLoan(loan, poolController, poolAdmin);

// Try again, even though there's technically enough money to cover the loan
await expect(
poolController.connect(poolAdmin).fundLoan(loan.address)
).to.be.revertedWith("Pool: already funded");
});
});

describe("defaultLoan()", () => {
Expand Down