We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello Chris, I am working on Errant for Czech and found the following line problematic:
errant/errant/en/merger.py
Line 64 in 6c0d521
The issue is that it is True even if start != 0 (if (len(c) == 1 and o[0].text[0].isupper()) gets evaluated to True.
(len(c) == 1 and o[0].text[0].isupper())
In such case, return on lines 66-67 will omit "the preceding part of combo".
I suppose that the fix is to enforce start == 0 by adding a pair of brackets:
if start == 0 and ((len(o) == 1 and c[0].text[0].isupper()) or \ (len(c) == 1 and o[0].text[0].isupper())):
The text was updated successfully, but these errors were encountered:
Heya,
Thanks for the report! Looks like a bracketing issue indeed so I'll make a note to fix it in the next version.
Sorry, something went wrong.
Fixed in v2.3.0
No branches or pull requests
Hello Chris,
I am working on Errant for Czech and found the following line problematic:
errant/errant/en/merger.py
Line 64 in 6c0d521
The issue is that it is True even if start != 0 (if
(len(c) == 1 and o[0].text[0].isupper())
gets evaluated to True.In such case, return on lines 66-67 will omit "the preceding part of combo".
I suppose that the fix is to enforce start == 0 by adding a pair of brackets:
The text was updated successfully, but these errors were encountered: