Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable trailing space highlighting in code blocks #240

Open
AlJohri opened this issue Jun 18, 2023 · 2 comments
Open

disable trailing space highlighting in code blocks #240

AlJohri opened this issue Jun 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@AlJohri
Copy link

AlJohri commented Jun 18, 2023

Is your feature request related to a problem? Please describe.
I find the bright pink trailing space highlighting very distracting. Example:

wget https://github.com/hyperium/tonic/raw/master/examples/helloworld-tutorial.md
glow helloworld-tutorial.md
Screenshot 2023-06-18 at 12 12 38 PM

Describe the solution you'd like
I expect to be able to render Markdown files like I would see them out in the wild on Github without the distracting highlighting for trailing spaces in code blocks. For example this is how helloworld-tutorial.md renders on Github.

Describe alternatives you've considered
alternative would be to to trim the file myself, but I expect to be able to read existing markdown files created by other people out of the box

@AlJohri AlJohri added the enhancement New feature or request label Jun 18, 2023
@bashbunni
Copy link
Member

Thanks for bringing this to our attention! I'm going to move it to our markdown rendering library so we can make sure it gets addressed in the upstream dependency.

@bashbunni bashbunni transferred this issue from charmbracelet/glow Jun 20, 2023
@bashbunni
Copy link
Member

fwiw this is happening because the trailing spaces are being rendered with GenericDeleted styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants