Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use errors.New to replace fmt.Errorf with no parameters will much better #986

Closed
wants to merge 1 commit into from
Closed

chore: use errors.New to replace fmt.Errorf with no parameters will much better #986

wants to merge 1 commit into from
+10 −8

Conversation

ChengenH
Copy link

use errors.New to replace fmt.Errorf with no parameters will much better

Delta456
Delta456 approved these changes Apr 21, 2024
View reviewed changes
Copy link

@Delta456 Delta456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors.New is indeed better for this usage.

@aymanbagabas aymanbagabas deleted the branch charmbracelet:main October 28, 2024 17:41
@aymanbagabas aymanbagabas reopened this Oct 28, 2024
@aymanbagabas aymanbagabas self-requested a review as a code owner October 28, 2024 17:50
@aymanbagabas aymanbagabas changed the base branch from master to main October 28, 2024 17:50
@ChengenH ChengenH closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delta456 Delta456 Delta456 approved these changes

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

@muesli muesli Awaiting requested review from muesli

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengenH @Delta456 @aymanbagabas