Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Visual Studio 2013 #1484

Closed
Cellule opened this issue Aug 24, 2016 · 7 comments
Closed

Support for Visual Studio 2013 #1484

Cellule opened this issue Aug 24, 2016 · 7 comments

Comments

@Cellule
Copy link
Contributor

Cellule commented Aug 24, 2016

I am wondering how long do we plan to support VS 2013?
In PR #1444 I started using constexpr on some functions to avoid using macros.

Before I reverted those change, I believe it would be worth checking if we planned to drop support soon.

@Cellule
Copy link
Contributor Author

Cellule commented Aug 24, 2016

@curtisman @digitalinfinity @dilijev @LouisLaf @MikeHolman Any thoughts on the matter ?

@dilijev
Copy link
Contributor

dilijev commented Aug 24, 2016

constexpr is a great feature we're missing out on. This isn't the first time it has come up. Since VS 2015 has a community edition that anyone can use for free, I'm seeing less of a compelling reason to keep supporting downlevel products because "people have already paid for those". Possibly you could argue "people are used to the workflow" but I don't think much of the community is depending on a VS 2013 workflow for our project.

@ianwjhalliday
Copy link
Collaborator

Agreed.

I may be mistaken, but I believe VS 2013 is the only non-fully compliant C++ 11 compiler we support. It would be nice to have the full C++11 feature set available for us to use, by dropping VS 2013.

I believe there were one or two other issues that came up where it would have been nice to have full C++11 support.

@tcare
Copy link
Contributor

tcare commented Aug 29, 2016

+1, though I seem to remember there being issues about downlevel and ARM.

@curtisman
Copy link
Contributor

Node still support building with VS2013.

@dilijev
Copy link
Contributor

dilijev commented Aug 30, 2016

^ And that right there is all the reason we need to keep supporting VS 2013. :P

@ianwjhalliday
Copy link
Collaborator

That is too bad. Doesn't mean node-chakracore needs to support VS2013, but reasonable to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants