-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recommendation of standard_name
or long_name
#515
Comments
On second thoughts, I realise that since it's not clear what to do, it would make sense to discuss it first in our new forum. Therefore I've opened a discussion of this question. Please comment there, rather than here. |
In the discussion, @davidhassell, @martinjuckes and I have agreed that this is a defect. I am therefore changing the label of this issue from I propose the changes described below to remedy the defect. Note also that I am proposing to update the text to replace "dimensionless" with "parametric (usually dimensionless)". That reflects the revision we made quite a long time ago in Section 4.3.3. In Section 1.4, replace this text
with
This removes the "recommendation" which causes the confusion. That recommendation is not necessary here, because it's included in Section 1.5 on "Relationship to the COARDS Conventions". The relevant sentence currently reads
which should be updated to read
In the preamble to Section 4, replace this text:
with
Here, I have retained the recommendation, but it's rephrased to make clear that it refers to the use of the convention for parametric vertical coordinates, rather than to the I have prepared pull request 520 to implement the above. In the PR, I have also corrected a couple of minor punctuation faults in Sect 1. Since this is a defect issue, the change will be accepted in the absence of any objection in three weeks, on 20th May. |
Thanks, @JonathanGregory. PR #520 looks fine to me (I've made one minor suggestion) |
Thanks, @davidhassell; I've committed your change to the PR. |
In commenting on #501 (now closed as completed), @martinjuckes drew attention to an apparent inconsistency. Section 3.2 says, "it is highly recommended that either [the
long_name
attribute] or thestandard_name
attribute defined in the next section be provided for all data variables and variables containing coordinate data." Both attributes are optional, and CF isn't recommending thestandard_name
more than thelong_name
in this sentence. That is consistent with Section 1.4 (the Overview), where it saysThis lack of preference between
long_name
andstandard_name
seems to be contradicted by two other sentences. In the preamble of Section 4, we haveand Section 1.4 says
The final sentence in each of those pieces of text apparently says that the
standard_name
is highly recommended, implying it's preferred to thelong_name
. My reading of those sentences, in context, is that "highly recommended" actually refers to the use of the convention of Section 4.3.3, "Parametric Vertical Coordinate", which involvesstandard_name
andformula_terms
, for those kinds of vertical coordinate where it's relevant. It is not saying thatstandard_name
is "highly recommended" (disregardinglong_name
) in all cases, so it's not inconsistent with Section 3.What do you think, @martinjuckes and anyone else? Is my reading correct?
In any case, I think we ought to clarify this. If my understanding is correct, this is a defect in the wording (a lack of clarity), which we can repair. If there is truly an inconsistency, sorting it out might be a change to the convention. Therefore I've labelled this as an
enhancement
for the moment, but we could change it to adefect
, depending on what you think.The text was updated successfully, but these errors were encountered: