-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard names: Add "Conventions" string to the standard name xml table header #500
Comments
@japamment Would this issue be suited for the cf-conventions repo? |
Following @japamment's suggestion I am migrating this to the cf-conventions repo. |
Hi folks, @DocOtak reached out from Antarctica, where the Internet's not so fast - I'm relaying on his behalf :) Btw looks like he's doing really well in the extreme south, it got me pretty jealous!
I might post some more stuff for him while he's away, but that's subject to the availability of time and email reception. Happy holidays all :) 🎄 |
Just to quickly respond to the points:
--- I don't know about case sensitivity. I am happy to change to whatever is agreed to here because it is simpler.
-- This was just to keep with the general style of abbreviating individual items in the Seasons greetings :-) |
While the exact text/string value to be used for the standard name conventions string is not settled I am nevertheless opening a PR to get this going. It will be easy to change the text once the string is agreed. |
And while preparing PR #503 I noticed that the current text in Appendix B is not quite up-to-date with the actual content of the standard name xml files . In particular the version_number is missing. Hence I also added this in the same PR. I invited @japamment and/or @feggleton as reviewers of the PR. Many thanks. |
Thanks for putting this together, Lars. It looks good to me. I would probably prefer |
Dear @larsbarring Thanks very much for this issue and PR. Please excuse my asking a question first about the principle. I agree with your proposal that it's useful to define a standard If we do include this new xml tag, I would prefer not abbreviating "standard", like @DocOtak and @davidhassell, because I think the full word is clearer. (For the same reason, we use very few abbreviations in the standard names themselves.) Also like @DocOtak, I would prefer lower case. I don't know whether xml is case-sensitive, but all the standard names are entirely lower case, and the CF convention says its controlled keywords are case-insensitive. I think that mixed case is more likely to lead to mistakes. For the name of the tag, I would suggest Thanks for your patience in considering these points. Best wishes Jonathan |
@JonathanGregory in response to your first point, I think there is merit to have a ready-made string that any software, or human, can easily access/understand, rather than require each and everyone implement/being aware of the exact rules laid down in "a document somewhere" ;-). This is a small thing within CF community but potentially a big thing in a larger context. I am happy to go with the slightly longer The PR has been updated accordingly. |
Thanks for your flexibility, @larsbarring. I accept the first point! Would you find |
Being ignorant about this, I have just searched on Google, and learned that xml tags are case-sensitive, and so is the text of the elements. |
@JonathanGregory The netCDF global attribute Based on this, my point of departure when making the proposal was (and still is) as follows:
Here are a couple of examples that I quickly gathered from https://www.unidata.ucar.edu/software/netcdf/conventions.html (I am sure there are plenty other):
where the first example refers to three separate conventions. I think that the suggested Hence I maintain that on balance |
I'm happy with |
Dear @larsbarring Thanks for your explanations and your patience. It's good to have the reasons. In that case, I'm happy to support your proposal of Best wishes Jonathan |
Thanks Jonathan for you flexibility, and all for your input and support. With this I think we can start the three weeks countdown. Also, I would like to note that the PR implements the change in |
See cf-convention.github.io/#433 regarding the last sentence in my previous comment. |
The three week countdown period (started on January 10) has has now passed with good margin. Can we merge the associated PR, @davidhassell would you mind? |
It would be an honour for me to do it, hoping that @davidhassell doesn't mind. Thanks, @larsbarring. |
The xml version of the table (available for download from this page) currently includes the following header information:
Suggestion:
Include a "Conventions string" in this header, i.e. a string that defines how the standard name table is to be specified in the NetCDF global
Conventions
attribute.For example:
If the header includes the line
it would be easy for some software to include this information in the
Conventions
attribute to give the followingncdump -h
output:Without this enhancement only the table version is know, which means that users/software either cannot add this information to the
Conventions
atribute, or have to "invent" a non-standardised string, which is contrary to the intended use.The text was updated successfully, but these errors were encountered: