Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in end-date in example 7.12 #449

Closed
heikoklein opened this issue Aug 25, 2023 · 5 comments · Fixed by #448
Closed

Typo in end-date in example 7.12 #449

heikoklein opened this issue Aug 25, 2023 · 5 comments · Fixed by #448
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors

Comments

@heikoklein
Copy link
Contributor

Example 7.12 describes the winter-season 2007-2008, but the climatological end-bound was given in August 2000. This is fixed to March 2008 in the PR.

Associated pull request

Link to associated pull request, if present.
#448
@JonathanGregory JonathanGregory added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Aug 25, 2023
@JonathanGregory
Copy link
Contributor

Dear Heiko

Thank you for reporting this and preparing a correction. I agree with the modification to the text of the example. Please could you add this issue to history.adoc.

This issue corrects a defect, and as such it will be accepted in three weeks (on 15th September) if no-one objects to it.

Best wishes

Jonathan

@JonathanGregory JonathanGregory linked a pull request Aug 25, 2023 that will close this issue
Update ch07.adoc, fix typo in example 7.12 #448
Merged
4 tasks
@heikoklein
Copy link
Contributor Author

Dear Jonathan,
the pull-request #448 has been updated to include this issue in history.adoc.
Best wishes,
Heiko

@JonathanGregory
Copy link
Contributor

Thanks again, Heiko.

@JonathanGregory
Copy link
Contributor

Three weeks have passed with no objection to this defect correction, so I will merge the pull request now. Thanks, @heikoklein.

@JonathanGregory
Copy link
Contributor

Before merging, I resolved a conflict at the top of history.adoc by reordering the most recent entries.

@larsbarring larsbarring mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ch07.adoc, fix typo in example 7.12
2 participants
@heikoklein @JonathanGregory