Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] create updateAttr method on XMLElement #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GeekTree0101
Copy link

I needs update attribute value on XMLElement,
If you don't mind, Please check it
Thank you

@cezheng
Copy link
Owner

cezheng commented Oct 31, 2017

I have thought about supporting modifying XML before, but this will require a major rewrite since the current implementation heavily relies on lazy.

For this PR, the attributes property will be broken.

@GeekTree0101
Copy link
Author

Okey I got it, thanks for code review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants