Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-status-view] Remove opt object and add proptype check #2178

Closed
yuderekyu opened this issue Jan 23, 2019 · 0 comments · Fixed by #2264
Closed

[terra-status-view] Remove opt object and add proptype check #2178

yuderekyu opened this issue Jan 23, 2019 · 0 comments · Fixed by #2264

Comments

@yuderekyu
Copy link
Contributor

Feature Request

We export variants with Statusview.opts.variants, let's remove the opts object, create a named export, and add a proptype check.

const StatusViewVariants = {
  NODATA: 'no-data',
  NOMATCHINGRESULTS: 'no-matching-results',
  NOTAUTHORIZED: 'not-authorized',
  ERROR: 'error',
  CUSTOM: 'custom',
};

variant: PropTypes.string.onOf([ 'no-data', 'no-matching-results', etc]);
...
...
export default StatusView;
export {StatusViewVariants}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants