Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EIP-2930 #64

Closed
i-norden opened this issue Apr 15, 2021 · 4 comments
Closed

Support EIP-2930 #64

i-norden opened this issue Apr 15, 2021 · 4 comments
Assignees

Comments

@i-norden
Copy link
Collaborator

Firstly just assert we can index EIP-2930 txs as normal, without the additional fields/rows and with no issues in storing them as IPLDs.

Secondly, adjust the code and database schemas to decode and index the new access list.

@i-norden
Copy link
Collaborator Author

i-norden commented Apr 27, 2021

We are running into error like this until we support it: statediff.Service.WriteLoop: processing error block height=12323727 error="error creating IPLD nodes from block and receipts: wrong transaction hash computed" worker=8

This is because for 2930 txs it is not just the RLP encoded tx that is stored in the trie, but rather 0x01 || RLP(tx) so the EncodeRLP() method does not work any more and we need to use MarshalBinary().

The same is true for receipts, except we need to add the MarshalBinary() method first.

@i-norden
Copy link
Collaborator Author

i-norden commented May 3, 2021

Addressed in #68

@AFDudley
Copy link

AFDudley commented May 4, 2021

https://vulcanize.slack.com/archives/CGY8XDDNZ/p1620102149463900

@i-norden
Copy link
Collaborator Author

i-norden commented Jun 4, 2021

I think we can close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants