-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Add Admin API support #27
Comments
I opted to integrate protobuf/gRPC and in the process have unearthed some complexity (I still think this is a fight worth having). Noting here to log findings: The This is troublesome for a couple of reasons, firstly because in order to fix imports, we'd be required to house all of our generated code in the package root (e.g. with each proto package next to I played around with trying to store proto generated code in a subdirectory and adding that subdirectory to At the moment I see two options:
Or I just do away with this altogether. I really like auto-generated classes and gRPC services, but this might be more trouble than it's worth. Will continue to explore for a little while and make a decision. |
The more I think about it, the happier I am with option 2. The SDK will ultimately be a thin convenience wrapper around the generated code. I might be able to reduce down the required modules, and then hopefully I'll be able to prevent access to each bar |
Those are the exact reasons why I decided to not use gRPC for Python SDK. I even tried to write a Rust module to handle the client interaction and make the Python SDK a thin wrapper on top of that. All of those approaches had some pretty gnarly issues to address and it felt like handcrafting the Python classes was much simpler. |
Adding support to interface with the Admin API
The text was updated successfully, but these errors were encountered: