Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extend onchain attestation #2557

Open
12 tasks
mustermeiszer opened this issue Dec 17, 2024 · 0 comments
Open
12 tasks

feat: Extend onchain attestation #2557

mustermeiszer opened this issue Dec 17, 2024 · 0 comments

Comments

@mustermeiszer
Copy link
Contributor

mustermeiszer commented Dec 17, 2024 •
edited by hieronx
Loading

The current onchain closed here needs some adjustments.

Tasks

  • Include onchainReserve in the assets-section - TAKE from runtimeApi Nav.reserve
  • Include ALL assets in the assets-section - currently, cash items are missing
  • Include total accrued-unpaid fees as 1 asset item - price = -1 with right decimals, TAKE from runtimeApi Nav.navFees
  • Adjust quantity field to pool decimals - currently, it is 18 decimals
  • Change asset structure
    • asset → assetId - 0 for onchainReserve
    • New asset → name retrieved for the asset from ipfs data, onchainReserve for onchainReserve
  • Remove netFeeValue
  • Add "tokenAddresses" → list addresses of tranche tokens on the relevant networks, identified by chainId - see json for details
  • Add timestamp when this was signed to portfolio - unix timestamp in seconds
  • Adapt signature to be a struct containing signature and publicKey of signer
  • Ensure netAssetValue is correct - TAKE from runtimeApi Nav.total

Resources

adjustedAttestation.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mustermeiszer