Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PayForMessage Tx type #4

Closed
liamsi opened this issue Jan 4, 2021 · 3 comments
Closed

Add PayForMessage Tx type #4

liamsi opened this issue Jan 4, 2021 · 3 comments
Labels

Comments

@liamsi
Copy link
Member

liamsi commented Jan 4, 2021

After #2 and #1, we should start implementing the LazyLedger specific transactions.

The relevant part of the spec: https://github.com/lazyledger/lazyledger-specs/blob/master/specs/data_structures.md#signedtransactiondatapayformessage

@tac0turtle
Copy link
Collaborator

tac0turtle commented Jan 4, 2021

This has some overlap with fee grant module: https://github.com/cosmos/cosmos-sdk/pull/5768/files. It would need to have some modifications but it's a good starting point. Here is the ADR: https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-029-fee-grant-module.md. This is something we could collaborate with the sdk team on and then modify to meet LL's need.

@liamsi
Copy link
Member Author

liamsi commented Jan 4, 2021

Thanks @marbar3778! This looks interesting but it seems relatively far away from the SignedTransactionDataPayForMessage? Although it plays into a discussion we had internally: namely, that ideally, one should not need to have LL tokens or to "maintain a wallet with sufficient fees". The PayForMessage Tx type still seems quite different but maybe I'm missing sth.

@liamsi liamsi added the P:High label Jan 4, 2021
@liamsi
Copy link
Member Author

liamsi commented Feb 18, 2021

The type will be added in the lazyledger-app / module instead of the SDK fork directly. See celestiaorg/celestia-app#21 and celestiaorg/celestia-app#22

@liamsi liamsi closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants