Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/getter): Cascade Getter Discards Successful Samples on Partial Failure #3964

Open
walldiss opened this issue Nov 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@walldiss
Copy link
Member

Implementation ideas

When using the cascade getter, if any of the requested samples fail to retrieve, the system retries the entire sampleCoordinates set with the next fallback getter. This process discards any samples that were successfully retrieved in the previous attempt. While this currently works because the bitswap getter is the last in the sequence, it may lead to issues if the order changes or additional getters are introduced. This behavior lacks proper support in the current implementation and could become problematic and difficult to debug in the future.

Suggested Improvement:
Implement proper handling for partial successes to ensure that retrieved samples are not discarded unnecessarily. Modify the cascade getter to retain successfully retrieved samples when retrying with fallback getters.

Becomes relevant after #3891 is merged

@walldiss walldiss added the enhancement New feature or request label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant