Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a proof that a transaction or message has been included in a block #416

Closed
evan-forbes opened this issue Jun 16, 2021 · 2 comments
Closed

Comments

@evan-forbes
Copy link
Member

Summary

Return a proof that a transaction or message has been included in a block via rpc.

Problem Definition

Currently, when asked to prove that a transaction has been included in a block, tendermint loads the block of a given height, and provide a simple proof. In order to provide the same functionality, celestia will have to selectively load the transaction data (#221) and extract a proof from IPFS.

Proposal

After saving and loading data via IPFS #374, finalizing node types, and being able to selectively load block data #221, we will be able to start implementing this proposal.

Implementation

It will likely take 2-4 PRs to close this issue. One to handle extracting proofs from IPFS, one to search for and find tx and msgs, and at least one more to handle changing the actual rpc code.

@liamsi
Copy link
Member

liamsi commented Jun 25, 2021

Note: this might impact the e2e tests in case they check for Tx with proofs. So in case we merge #218 and only store data in ipfs, we might have to disable proof checking until we fixed this issue at hand.

@evan-forbes
Copy link
Member Author

We still have to return a proof that a PayForMessage is included in the block, but I don't think this issue is relevant any longer since it is focused on using IPFS to store block data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants