Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build performance with Helm charts #1195

Closed
aca opened this issue Feb 20, 2023 · 1 comment
Closed

Build performance with Helm charts #1195

aca opened this issue Feb 20, 2023 · 1 comment
Labels
closed-for-staleness Issue/PR was closed due to staleness effort/medium 1 week tops feature-request New/Enhanced functionality wanted priority/p1 Should be on near term plans

Comments

@aca
Copy link

aca commented Feb 20, 2023

With more than 10+ helm charts it takes almost 60 seconds to build whole applications with cdk8s.
It may not be an issue of cdk8s but it will be great if there's something we can do for it.

Related issues


Here's a trick I'm using to fix this. With bkt, we can create wrapper for helm cli and use it to build cdk8s applications.

build.sh

export HELM_BINARY=$(which helm)
export PATH=$(pwd)/hacks:$PATH
npm run build

hacks/helm

#!/usr/bin/env bash
set -euo pipefail
[[ -z $TMPDIR ]] && exit 1; [[ -z $HELM_BINARY ]] && exit 1

FILECACHE_DIR="/tmp/_filecache"
filecache() {
    mkdir -p $FILECACHE_DIR >/dev/null 2>&1 || true
    chksum=$(md5sum < "$1" |  awk '{ print $1 }')
    cp -n "$1" "$FILECACHE_DIR/$chksum" >/dev/null 2>&1 
    echo "$FILECACHE_DIR/$chksum"
}

args=("$@")
for ((i=0; i<"${#args[@]}"; ++i)); do
    case ${args[i]} in
        ${TMPDIR}*.yaml) args[i]=$(filecache "${args[i]}")
    esac
done

bkt --ttl 24h -- "$HELM_BINARY" "${args[@]}"
@aca aca changed the title build performance with Helm charts Build performance with Helm charts Feb 20, 2023
@iliapolo iliapolo added the needs-triage Priority and effort undetermined yet label Feb 27, 2023
@vinayak-kukreja vinayak-kukreja added feature-request New/Enhanced functionality wanted effort/medium 1 week tops priority/p1 Should be on near term plans and removed needs-triage Priority and effort undetermined yet labels Aug 16, 2023
Copy link
Contributor

This issue has not received any attention in 1 year and will be closed soon. If you want to keep it open, please leave a comment below @mentioning a maintainer.

@github-actions github-actions bot added the closing-soon Issue/PR will be closing soon if no response is provided label Aug 15, 2024
@github-actions github-actions bot added closed-for-staleness Issue/PR was closed due to staleness and removed closing-soon Issue/PR will be closing soon if no response is provided labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness Issue/PR was closed due to staleness effort/medium 1 week tops feature-request New/Enhanced functionality wanted priority/p1 Should be on near term plans
Projects
None yet
Development

No branches or pull requests

3 participants