remove bower #1040
Merged
remove bower #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanfeld
approved these changes
Jun 2, 2023
radhikav1
reviewed
Jun 6, 2023
njbriggs
approved these changes
Jun 6, 2023
radhikav1
approved these changes
Jun 7, 2023
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove bower
Description
TLDR;
Move the dependencies managed by bower to yarn and remove bower.
Currently, some of the dependencies (legacy) are being managed by bower. However, bower is not in active development and it's recommended to migrate to yarn. In this PR we have migrated the dependencies and removed bower, with the following changes to the codebase:
package.jsonto be managed byyarn >= 1.0.bower_componentshave been moved tonode_modules/@bower_components. All references tobower_componentsin the codebase have been updated accordingly.bower_roothas been deprecated and the corresponding step in the github build workflow has been removed.README.mdhas been updated to remove thebower installstep.PR Type
Links
Jira: CDAP-14285
Test Plan
Local build: pass
Github build workflow: pass
e2e tests: pass
Manual tests: wip
Screenshots
NA