-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more text colouring #27
Comments
@mbeckrich this should be doable but it'll need a dedicated decorations.scss file I think |
@qdgiang01 Will implement. @AnubisNekhet Sounds good, going to get started on it rn but have appointments all afternoon so might not get done until tomorrow-ish. |
This is what I'm looking at right now for the full palette theme @AnubisNekhet. Open to any changes, put this on development for the time being. Will tackle the Style Settings/accent themes when I get home. |
Sounds good 👍 |
A first go at this has just been pushed to main. I'll leave this issue open for the time being in case anyone has feedback. Didn't have time tonight, but I will integrate the font color choices with Style Settings soon. |
As of 24020e3, people with the Style Settings plugin should be able to swap out the default theme's colors for headings, italics, bold, strikethrough, and blockquote with their preferred colors from the palette. For anyone who wants to make their own modifications (e.g. change default colors themselves, mess with opacity, etc.), I thought I would be able to do something in Style Settings like: id: ctp-bold
type: variable-select
default: var(--ctp-sapphire) strong,
cm-strong {
--bold-color: rgb(var(--ctp-bold);
} But this method only works once the user selects a color. The --ctp-sapphire variable doesn't seem to go anywhere until then and if you do pick the color and then hit the plugin's default button, the color resets to grey and not the default from the yaml. If this is common knowledge, my bad, but the /*_typography.scss*/
strong,
.cm-strong {
--bold-color: rgb(var(--ctp-bold, var(--ctp-sapphire)));
} |
Would be great if we are able to colour the bold, italic, quoted… text like Things theme combined with the Style settings plugin. Texts will be much clearer and also take advantage of the full colour palette.
The text was updated successfully, but these errors were encountered: