Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catppuccin 0.2.0 #15

Closed
nekowinston opened this issue Aug 8, 2022 · 4 comments
Closed

Catppuccin 0.2.0 #15

nekowinston opened this issue Aug 8, 2022 · 4 comments

Comments

@nekowinston
Copy link
Contributor

Hi there 👋
Thanks for your work on this port of Catppuccin!

Just want to check in and ask if there is an update to the 0.2.0 spec in the pipeline, or if it is something where help is needed.

I've had a look at the repo structure, and it seems that abstracts/_colors.scss is not used at all?

/* make any changes to colors in base.scss instead */

It also seems that #14 introduced a discrepancy between .theme-dark and .theme-light:

--background-modifier-border: hsl(249deg 16% 32%);

--background-modifier-border: hsl(249deg 23% 12%);

Wouldn't it be possible to use a combined selector .theme-dark, .theme-light {} instead?

I've got quite a bit on my personal Catppuccin To-do list already, so I essentially just want to get the conversation regarding the update started.

@mbeckrich
Copy link
Collaborator

I'll revisit the theme this week. I haven't been using Obsidian much recently, so the theme hasn't gotten the time it deserves. If memory serves, there was a reason I had kept light and dark separated, but can't remember exactly why. Maybe Obsidian asks its theme creators to do that? Not sure, but will investigate and combine if allowed. Thanks for reaching out.

@nekowinston
Copy link
Contributor Author

nekowinston commented Aug 10, 2022

I forgot to mention two things:

The isLatte shorthand is super useful since Latte is pretty much guaranteed to look off, when just using the same colour names across all flavours.
https://github.com/nekowinston/asciicinema/blob/bb48cf33bddc6ba4e4c73f4b296335312dacfa28/src/_theme.scss#L2-L20

@mbeckrich
Copy link
Collaborator

Awesome, thanks! I updated the colors last night, so the theme should now be compliant with the most recent Mocha palette. I still need to cleanup and organize the scss files and I have a massive list of little visual annoyances I need to work on.

I've forked your demo repo and will give it a go. Unless something has changed with the way Obsidian works, it can by default only alternate between a light and dark theme. A few of the bigger themes have their own settings plugins to adjust color palette easily, but that's probably a longer term project for me. In the meantime, I should be able to rig something up that allows for easy switching using the Style Settings plugin. Or I can create snippets for the palettes that users can toggle on/off in Appearance -> Settings. Let me know if you have a preference/other ideas.

@mbeckrich
Copy link
Collaborator

Update: I've asked the Obsidian Discord what their preferred method of incorporating multiple palettes into a theme is. Right now, the feedback I'm getting is that this plugin https://github.com/mgmeyers/obsidian-style-settings is the best way to go. As long as there are no objections and Style Settings works with 0.16.0, I will incorporate the non-Mocha palettes into the plugin while I work on the 0.16.0 update #16. I understand this creates some friction for users wanting to access all the palettes, so I will give detailed instructions for the plugin's use in the readme and hopefully there will be a better solution at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants