-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glob doesn't find anything on windows #191
Comments
Looks like others are also running into this issue: I can't really test on a Windows setup unfortunately so I'm thinking out loud here... It looks like the I can't really make it a default because that could cause breaking changes for users on Windows that actually want to escape characters, which is why the was made in |
Yeah, should be good enough, in the mean time I forced version 7.2.0 and everything works as it used to be. |
in react native throws same error |
Glob 7.2.3 was released a few hours ago, which should contain the fix to this issue. |
I'm closing this as this seems to be resolved, feel free to comment if I misinterpreted 😘 |
Description
I have a folder with a bunch of SVG files on windows, I set SVGSpriteMapPlugin like this:
But once I run it it seems that path gets normalized here in line 63 back to backslash based lines which doesnt seem to work with glob.sync anymore (updateDependencies function)
I'm pretty sure i'm missing something here because this used to work for me up until I reinstalled the entire node_modules,
that being said, I did find this node-glob issue which seems to say the same thing.
see also this one
my hacky solution in the meantime is to override use to glob 7.2.0
Expected behavior
The svg files are found no matter what system you use
Actual behavior
glob doesn't find any svg files if the paths are normalized to windows (using backlashes)
System information
Windows 10
Minimal reproduction
Minimal Example
The text was updated successfully, but these errors were encountered: