Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] rxjs-prefer-angular-composition for services. #120

Open
distante opened this issue Jan 2, 2021 · 2 comments
Open

[Request] rxjs-prefer-angular-composition for services. #120

distante opened this issue Jan 2, 2021 · 2 comments

Comments

@distante
Copy link

distante commented Jan 2, 2021

Angular services also can use the OnDestroy, if subscriptions are done there for background tasks, we should be able to link them as "use a subscription object and unsubscribe on OnDestroy"

@cartant
Copy link
Owner

cartant commented Jan 2, 2021

The ESLint version of this rule supports classes other than components. I'm not really interested in adding features/functionality to this package of rules now that TSLint has reached its end of life.

@distante
Copy link
Author

distante commented Jan 2, 2021

Fair enough. I can not change my project to ESLint at the time until all my dependencies support it so I supposse I have to just live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants