fix: Account for subscriber chaining.

cartant · Nov 5, 2020 · a821e82 · a821e82
1 parent 0464f87
commit a821e82
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/source/rules/rxjsNoIgnoredSubscriptionRule.ts b/source/rules/rxjsNoIgnoredSubscriptionRule.ts
@@ -46,6 +46,15 @@ export class Rule extends Lint.Rules.TypedRule {
           propertyAccessExpression.expression
         );
         if (couldBeType(type, "Observable")) {
+          if (
+            callExpression.arguments.length === 1 &&
+            couldBeType(
+              typeChecker.getTypeAtLocation(callExpression.arguments[0]),
+              "Subscriber"
+            )
+          ) {
+            return;
+          }
           const { name } = callExpression.expression;
           failures.push(
             new Lint.RuleFailure(

diff --git a/test/v6/fixtures/no-ignored-subscription/default/fixture.ts.lint b/test/v6/fixtures/no-ignored-subscription/default/fixture.ts.lint
@@ -1,4 +1,4 @@
-import { of, Subscription } from "rxjs";
+import { of, Subscriber, Subscription } from "rxjs";
 
 of(42).subscribe();
        ~~~~~~~~~                            [no-ignored-subscription]
@@ -9,4 +9,7 @@ b = of(42).subscribe();
 const c = [of(42).subscribe()];
 const d = { subscription: of(42).subscribe() };
 
+const subscriber = new Subscriber<number>();
+of(42).subscribe(subscriber);
+
 [no-ignored-subscription]: Ignoring returned subscriptions is forbidden