fix(unbound): Validate only functions.

cartant · Jul 1, 2018 · 251a075 · 251a075
1 parent 804ad3c
commit 251a075
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/source/rules/rxjsNoUnboundMethodsRule.ts b/source/rules/rxjsNoUnboundMethodsRule.ts
@@ -78,11 +78,17 @@ class Walker extends Lint.ProgramAwareRuleWalker {
     }
 
     private validateArgs(args: ts.NodeArray<ts.Expression>): void {
+
+        const typeChecker = this.getTypeChecker();
+
         args.forEach(arg => {
             if (tsutils.isPropertyAccessExpression(arg)) {
-                const thisKeywords = tsquery(arg, `ThisKeyword`);
-                if (thisKeywords.length) {
-                    this.addFailureAtNode(arg, Rule.FAILURE_STRING);
+                const type = typeChecker.getTypeAtLocation(arg);
+                if (type.getCallSignatures().length > 0) {
+                    const thisKeywords = tsquery(arg, `ThisKeyword`);
+                    if (thisKeywords.length > 0) {
+                        this.addFailureAtNode(arg, Rule.FAILURE_STRING);
+                    }
                 }
             }
         });

diff --git a/test/v6/fixtures/no-unbound-methods/static/fixture.ts.lint b/test/v6/fixtures/no-unbound-methods/static/fixture.ts.lint
@@ -24,7 +24,7 @@ class Something {
     static error(error: any): void {}
     static map<T>(t: T): T { return t; }
     static next<T>(t: T): void {}
-    tearDown(): void {}
+    static tearDown(): void {}
 }
 
 [no-unbound-methods]: Unbound methods are forbidden