no-ignored-replay-buffer doesn't check bufferSize if object config passed to shareReplay
#100
Comments
skrtheboss
added a commit
to skrtheboss/eslint-plugin-rxjs
that referenced
this issue
May 12, 2023
…ption for shareReplay Fixes cartant#100
JasonWeinzierl
added a commit
to JasonWeinzierl/eslint-plugin-rxjs-x
that referenced
this issue
Nov 8, 2024
Fixes cartant#100 There's also a proposed fix PR in the upstream repo cartant#114 but I avoided looking at that solution to avoid any license issue, so this solution might be different. - Fix: if the `shareReplay` operator was passed an object config, then require `bufferSize` to be in that object. - Fix: the rule wasn't handling if `shareReplay` is imported under a namespace. - (Might need to review the entire project. Since rxjs now recommends importing from "rxjs" instead of "rxjs/operators", there's a risk that many rules also fail to account for that new paradigm. Note that this rule is the only rule that tests namespace imports for all cases, so we at least should expand that coverage/type of test.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my project I'm using
plugin:rxjs/recommendedwhich comes with two rules:rxjs/no-sharereplayandrxjs/no-ignored-replay-buffer.The following code is good with
rxjs/no-ignored-replay-bufferrule and throws error withrxjs/no-sharereplayrule:And this won't throw any linter error:
But
bufferSizehere is missing. And it looks like here should be error fromrxjs/no-ignored-replay-bufferrule. I've checked sources and it looks like the rule check only arguments length but doesn't check the arguments content.Also, I can help with pull request, if you don't mind.
The text was updated successfully, but these errors were encountered: