Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust s3 path resolve #378

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

More robust s3 path resolve #378

wants to merge 5 commits into from

Conversation

ennoruijters
Copy link
Contributor

@ennoruijters ennoruijters commented Sep 28, 2021 •
edited
Loading

Pull Request Description

This pull request closes #377.

Acceptance Test

  • Building the code with mvn clean install -Punit-tests,it-minio,it-s3 still works.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No

  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No

  • Does this require an update of the documentation?

    • Yes, please see [provide details here]
    • No

@ennoruijters ennoruijters force-pushed the more-robust-S3Path-resolve branch 2 times, most recently from 834e674 to f2fdf7e Compare September 29, 2021 09:26
@carlspring carlspring force-pushed the more-robust-S3Path-resolve branch from 3976e73 to 6ac8019 Compare June 7, 2023 00:36
@steve-todorov steve-todorov force-pushed the more-robust-S3Path-resolve branch from 6ac8019 to dfc606f Compare July 25, 2023 23:37
@steve-todorov steve-todorov temporarily deployed to external-collaborators July 25, 2023 23:37 — with GitHub Actions Inactive
@steve-todorov steve-todorov temporarily deployed to external-collaborators July 25, 2023 23:37 — with GitHub Actions Inactive
@steve-todorov steve-todorov temporarily deployed to external-collaborators July 25, 2023 23:37 — with GitHub Actions Inactive
@steve-todorov steve-todorov temporarily deployed to external-collaborators July 25, 2023 23:37 — with GitHub Actions Inactive
@steve-todorov steve-todorov temporarily deployed to external-collaborators July 25, 2023 23:37 — with GitHub Actions Inactive
@steve-todorov steve-todorov temporarily deployed to external-collaborators July 25, 2023 23:37 — with GitHub Actions Inactive
@steve-todorov steve-todorov added this to the 1.0.3 milestone Jul 26, 2023
@steve-todorov steve-todorov modified the milestones: 1.0.3, backlog Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
backlog
Development

Successfully merging this pull request may close these issues.

Support S3Path.resolve(Path) for non-S3Path arguments
3 participants
@ennoruijters @steve-todorov @carlspring