-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦴 for tag commits related to markup #1300
Comments
Could you share more about “Adding new tags or modifying the current ones for another more convenient for your purposes.” I personally have not defined tags in a long time, /slash relate that to “new component,” which may fall under some existing use cases. Sharing some emojis I thought of when reading this issue.
Again, mostly curious about what specific markup changes you were thinking. |
Hi @connorjs, thank you for your comment. I found ✨ more appropriate for complete features (like at this moment, the user is able to do whatever), ♿ directly related to accessibility concerns, 💄 for modifications on the visual output as well as 🚸. From my point of view, 🦴 is intended to describe the basic HTML structure of a component, for example; the very first attempt for creating a breadcrumb component is to scratch its structure (before adding styles or populating it with some data) <ol>
<li><a href="#">item 1</a></li>
<li><a href="#">item 2</a></li>
<li>item 3</li>
</ol> And this represents a single commit that may be pushed. After that, the style layer could be applied 💄, some I love to write HTML and gitmoji, but so often, after adding a not planned |
If that basic structure first commit planned to have follow ups, I would use 🚧. If it is standalone, maybe ✨ still, but I see the desire for something specific. Maybe others will comment or +1 this too. |
I see your point. I hope anyone else supports this need. Thank you! |
Emoji symbol
🦴
Emoji code
🦴
Emoji description
Used for tag a commit related to the markup of your interface.
Describe the use case of your emoji
When creating an interface or component to easily understand that the commit is related to the markup: HTML, JSX, etc. Adding new tags or modifying the current ones for another more convenient for your purposes.
Is this use case covered by an existing emoji?
No ❌
Does this emoji fall into the "how" or the "what" category?
Examples
🦴 Add an ordered list for breadcrumbs
🦴 Use BUTTON instead of A tag
🦴 Scratch component
Validations
The text was updated successfully, but these errors were encountered: