Add some missing bounds checks. #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Apr 17, 2018
src/frame/headers.rs
Outdated
| @@ -153,6 +153,9 @@ impl Headers { | |||
|
|
|||
| // Read the padding length | |||
| if flags.is_padded() { | |||
| if src.len() < 1 { | |||
| return Err(Error::MalformedMessage); | |||
| } | |||
| // TODO: Ensure payload is sized correctly | |||
There was a problem hiding this comment.
Maybe there's more involved, but wanted to check: does this addition essentially complete this TODO?
There was a problem hiding this comment.
Seems like it; I removed the comment.
src/proto/streams/streams.rs
Outdated
| @@ -322,6 +322,10 @@ where | |||
| let last_stream_id = frame.last_stream_id(); | |||
| let err = frame.reason().into(); | |||
|
|
|||
| if actions.recv.max_stream_id() < last_stream_id { | |||
There was a problem hiding this comment.
I got a bit confused with this, until I went digging into recv to read the comments about max_stream_id. Whatcha think if there was a comment right here just saying to the effect of "if a new GOAWAY has a higher stream id than a previous GOAWAY, that's bad"?
|
Thanks @goffrie! Looks like the fuzzing has been submitted in another PR. I'm good with this! |
carllerche
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran a fuzzer and found a few places where we were panicking instead of returning errors.