Merge pull request #3756 from canonical/remove-default-mount-target-f…

…rom-launch

[cli/launch] remove default mount target from --mount

src/client/cli/cmd/launch.cpp

@@ -347,10 +347,9 @@ mp::ParseCode cmd::Launch::parse_args(mp::ArgParser* parser)
         for (const auto& value : parser->values(mountOption))
         {
             // this is needed so that Windows absolute paths are not split at the colon following the drive letter
-            auto colon_split = QRegularExpression{R"(^[A-Za-z]:[\\/].*)"}.match(value).hasMatch();
-            auto mount_source = value.section(':', 0, colon_split);
-            auto mount_target = value.section(':', colon_split + 1);
-            mount_target = mount_target.isEmpty() ? mount_source : mount_target;
+            const auto colon_split = QRegularExpression{R"(^[A-Za-z]:[\\/].*)"}.match(value).hasMatch();
+            const auto mount_source = value.section(':', 0, colon_split);
+            const auto mount_target = value.section(':', colon_split + 1);
 
             // Validate source directory of client side mounts
             QFileInfo source_dir(mount_source);

tests/test_cli_client.cpp

@@ -1235,7 +1235,7 @@ TEST_F(Client, launch_cmd_mount_option)
     const QTemporaryDir fake_directory{};
 
     const auto fake_source = fake_directory.path().toStdString();
-    const auto fake_target = fake_source;
+    const auto fake_target = "";
     const auto instance_name = "some_instance";
 
     const auto mount_matcher = make_mount_matcher(fake_source, fake_target, instance_name);