v3: Add make-official-release script #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
commented
Oct 15, 2024
|
@Florent-Bouisset I don't get prettier's issue and the GitHub's VSCode WebIDE don't see it either. Can you look at it? |
scripts/update-version
Outdated
| @@ -50,4 +50,4 @@ echo "creating types for legacy code bases..." | |||
| rm -f dist/rx-player.d.ts rx-player.min.d.ts | |||
| echo "${copyright_text} | |||
| import RxPlayer from \"./_esm5.processed/minimal\"; | |||
| export default RxPlayer;" | tee dist/rx-player.d.ts dist/rx-player.min.d.ts >/dev/null | |||
| export default RxPlayer;" | tee dist/rx-player.d.ts dist/rx-player.min.d.ts > /dev/null | |||
There was a problem hiding this comment.
nothing but github complaining about not having a new line at end of file
There was a problem hiding this comment.
I added a line because I don't mind much, so if it can make some website's robot happier, happy to help!
peaBerberian
added
script
Yes, done! |
Florent-Bouisset
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to backport #1524 to the v3 so we can easily make a v3 release.
However due to a cascade of hardware issues, I currently cannot use any other software than a web browser basically.
Navigating through unfamiliar web-only tools (mainly VSCode so familiar to many, but I wasn't nor with any other non-terminal editor), I did my backport, but seeing now the diff on GitHub's interface for the first time it seems that the development was already backported and that this PR only fixes some mistakes.
Well, this PR's modifications still have a point, so I keep it.