DRM: Re-create MediaKeys for each content on Philips' NETTV #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
bug
peaBerberian
force-pushed
the
fix/titan-os-media-keys
branch
2 times, most recently
from
4117232 to
a30cae7
Compare
peaBerberian
force-pushed
the
fix/titan-os-media-keys
branch
from
a30cae7 to
b21fdb6
Compare
Fixes #1464 There's a new device (after LG and Panasonic TVs) which seems to have issues when relying on the same `MediaKeys` instance on multiple contents, which seems to be Philips's NETTV (both 2023 and 2024 devices seem to have the issue as far as we know, and they advertise completely different operating systems, so instead we identified the culprit as "NETTV", which seems to be the web browser application Philips developed for their TVs and which is present on web applications' user agent on those devices). So I disable the possibility for them here. I still have to check if it works because I took as user-agent something I found a little randomly on the web. Note that disabling re-usage of the `MediaKeys` instance will mean no in-memory `MediaKeySession` caching, which is a trick we use to both speed up loading a previous content and preventing to much requests on the license server also when doing that. But we know most other players don't seem to do such tricks and the speed up is not that much noticeable, so that shouldn't be a big issue.
peaBerberian
force-pushed
the
fix/titan-os-media-keys
branch
from
b21fdb6 to
d51b338
Compare
peaBerberian
added
the
Priority: 0 (Very high)
Florent-Bouisset
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1464
There's a new device (after LG and Panasonic TVs) which seems to have issues when relying on the same
MediaKeysinstance on multiple contents, which seems to be Philips's NETTV (both 2023 and 2024 devices seem to have the issue as far as we know, and they advertise completely different operating systems, so instead we identified the culprit as "NETTV", which seems to be the web browser application Philips developed for their TVs and which is present on web applications' user agent on those devices).So I disable the possibility for them here.
I still have to check if it works because I took as user-agent something I found a little randomly on the web.
Note that disabling re-usage of the
MediaKeysinstance will mean no in-memoryMediaKeySessioncaching, which is a trick we use to both speed up loading a previous content and preventing to much requests on the license server also when doing that.But we know most other players don't seem to do such tricks and the speed up is not that much noticeable, so that shouldn't be a big issue.