Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom scope for tokens #21

Closed
jwulf opened this issue Feb 5, 2024 · 2 comments
Closed

Support custom scope for tokens #21

jwulf opened this issue Feb 5, 2024 · 2 comments
Assignees
Milestone

Comments

@jwulf
Copy link
Member

jwulf commented Feb 5, 2024

SDK Component

OAuth component, and Zeebe client (if it doesn't use the OAuth component)

Expected Behavior

Has the ability to specify the token scope via env var and constructor to support custom identity providers. See: camunda/camunda-modeler#4102

Current Behavior

OAuth hardcodes the scopes per component.

@jwulf jwulf self-assigned this Feb 5, 2024
@jwulf jwulf added this to the 8.5.0 milestone Feb 5, 2024
nikku added a commit to nikku/zeebe-client-node-js that referenced this issue Feb 29, 2024
nikku added a commit to nikku/zeebe-client-node-js that referenced this issue Feb 29, 2024
jwulf added a commit to camunda-community-hub/zeebe-client-node-js that referenced this issue Mar 1, 2024
* feat: support configuration of OAuth `scope`

Related to camunda/camunda-modeler#4102

Implements camunda/camunda-8-js-sdk#21

* chore(types): `ZClientOptions#hostname` can be null

Returned internally as `null`.

* test: rewrite test cleanup

Ensures we properly clean up after each test,
also in cases of test failures.

* Small tweaks

* update CHANGELOG

---------

Co-authored-by: Josh Wulf <[email protected]>
@jwulf
Copy link
Member Author

jwulf commented Mar 5, 2024

It has been added for the components that use the shared OAuth component (all clients except the Zeebe client).

The next step is to either:

(a) port the scope threading to the Zeebe client in this repo; or
(b) refactor the Zeebe client in this repo to use the shared OAuth component.

@jwulf
Copy link
Member Author

jwulf commented Mar 6, 2024

The Zeebe client now uses the shared OAuth component. See this PR: #46

@jwulf jwulf closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant