You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
My expectation is that this code would be valid TypeScript
Current Behavior
The expected type of connectionTolerance is number. However, the type of Duration.seconds.of(3.5) is Seconds.
Possible Solution
Not quite sure which would be better... to update the type of connectionTolerance or to update the example... probably the first? Maybe change it to number | Seconds?
Steps to Reproduce
Just try to compile the example code in TS
Context (Environment)
Just trying to get started with this module... I'll probably just change it to 3500, but it did take me a while to ferret out what units I should be using (seconds or microseconds)
The text was updated successfully, but these errors were encountered:
The example code in the README that I'm referring to is this:
Expected Behavior
My expectation is that this code would be valid TypeScript
Current Behavior
The expected type of
connectionTolerance
isnumber
. However, the type ofDuration.seconds.of(3.5)
isSeconds
.Possible Solution
Not quite sure which would be better... to update the type of
connectionTolerance
or to update the example... probably the first? Maybe change it tonumber | Seconds
?Steps to Reproduce
Just try to compile the example code in TS
Context (Environment)
Just trying to get started with this module... I'll probably just change it to
3500
, but it did take me a while to ferret out what units I should be using (seconds or microseconds)The text was updated successfully, but these errors were encountered: