Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

MaxRetries in constructor not honoured #228

Closed
jwulf opened this issue Jun 3, 2021 · 0 comments
Closed

MaxRetries in constructor not honoured #228

jwulf opened this issue Jun 3, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jwulf
Copy link
Member

jwulf commented Jun 3, 2021

Expected Behavior

Specifying maxRetries in the ZBClient constructor should set the maximum number of operation retries.

For example:

const zbc = new ZBClient({
    retry: true,
	maxRetries: 3,
	maxRetryTimeout: 5000
})

Current Behavior

No matter what value is passed for maxRetries in the constructor, it uses the default of 50 retries.

Possible Solution

Make sure the configuration hydrator uses the constructor options for retries.

@jwulf jwulf self-assigned this Jun 3, 2021
@jwulf jwulf added bug Something isn't working and removed triage labels Jun 3, 2021
@jwulf jwulf closed this as completed in 0d9c093 Jun 3, 2021
jwulf added a commit that referenced this issue Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant