fix: validate arguments correctly #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/validate-args
branch
3 times, most recently
from
bb84682 to
74c8f90
Compare
currently the arguments are not validated correctly (#722) since they are validated against filtered questions. this fixes it to validate against the full list of questions. this also refactors the prompts module to move argument handling to the prompt function.
satya164
force-pushed
the
@satya164/validate-args
branch
from
74c8f90 to
677c6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the arguments are not validated correctly (#722) since they are validated against filtered questions. this fixes it to validate against the full list of questions.
this also refactors the prompts module to move argument handling to the prompt function.